Mukul Kumar Singh commented on HDFS-13116:

Thanks for the review [~anu], I have addressed the review comments.

Conduit --> Something like PipelineInfo
bq. Done, changed this to PipelineChannel

    interface to Abstract --I am wondering if this makes future changes less 
flexible. For example, if we have erasure coded pipelines, I am not sure if 
this abstract class implementation would work. But for the current case of 
stand-alone and Ratis, I do see it works well.
bq. I agree, I converted interface to abstract to avoid duplication of code.

Shouldn't we throw after the error, or do you want to return a new pipeline 
with conduit equal to null?
bq. returning null to conform with the existing behvaviour.

Should this function be protected via a synchronized keyword or a lock?
bq. Done, I have added synchronized to {{getPipeline}}, this function calls 
{{findOpenPipelineChannel}}, which will also be syncronized when 
{{getPipeline}} is syncronized.

> Ozone: Refactor Pipeline to have transport and container specific information
> -----------------------------------------------------------------------------
>                 Key: HDFS-13116
>                 URL: https://issues.apache.org/jira/browse/HDFS-13116
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>            Priority: Major
>             Fix For: HDFS-7240
>         Attachments: HDFS-13116-HDFS-7240.001.patch, 
> HDFS-13116-HDFS-7240.002.patch, HDFS-13116-HDFS-7240.003.patch, 
> HDFS-13116-HDFS-7240.004.patch, HDFS-13116-HDFS-7240.005.patch, 
> HDFS-13116-HDFS-7240.006.patch
> Currently pipeline has information about both the container as well Transport 
> layer. This results in cases where a new pipeline (i.e. transport) 
> information is allocated for each container creation.
> This code can be refactored so that the Transport information is separated 
> from the container, then the {{Transport}} can be shared between multiple 
> pipelines/containers.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to