[
https://issues.apache.org/jira/browse/HDFS-11600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358077#comment-16358077
]
SammiChen commented on HDFS-11600:
----------------------------------
Hi [~andrew.wang], the idea of using JUnit parameterize to really good, it
helps to cleanup the messy test cases. I took a further look into the
TestDFSStripedOutputStreamWithFailure. Many test cases are constant, not
related with parameter. So I think we can further split the
TestDFSStripedOutputStreamWithFailure into 2 files, one with constant test
case, another is parameterized. What do you think? By the way, If you don't
have too much time lately, I can take over it.
> Refactor TestDFSStripedOutputStreamWithFailure test classes
> -----------------------------------------------------------
>
> Key: HDFS-11600
> URL: https://issues.apache.org/jira/browse/HDFS-11600
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0-alpha2
> Reporter: Andrew Wang
> Priority: Minor
> Attachments: HDFS-11600-1.patch, HDFS-11600.002.patch
>
>
> TestDFSStripedOutputStreamWithFailure has a great number of subclasses. The
> tests are parameterized based on the name of these subclasses.
> Seems like we could parameterize these tests with JUnit and then not need all
> these separate test classes.
> Another note, the tests will randomly return instead of running the test.
> Using {{Assume}} instead would make it more clear in the test output that
> these tests were skipped.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
