Xiao Chen commented on HDFS-13135:

Thanks for reporting this and providing a patch Sean! Appreciate Kihwal's 
comment too.

I tried to play with the code, but not able to let the test fail, with or 
without the fix... Does it fail for you locally?

Looking at the test case, I think this is very similar to HDFS-12369. The unit 
test of that one 
({{TestDeleteRace#testDeleteAndLeaseRecoveryHardLimitSnapshot}}) was basically 
the same: keep a file unclosed, then delete it. Only difference at that time is 
(IIRC) a hard lease expiration was necessary to trigger the edits corruption. 
Not sure if this is the bug fix Kihwal was mentioning.... hopefully not. But if 
that is, and we want to do a different fix, I'm open to it. Suffice it to say, 
I should quote the famous line - I'm not a snapshot expert. :)

> Lease not deleted when deleting INodeReference
> ----------------------------------------------
>                 Key: HDFS-13135
>                 URL: https://issues.apache.org/jira/browse/HDFS-13135
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Major
>         Attachments: HDFS-13135.001.patch
> In troubleshooting an occurrence of HDFS-13115, it seemed that there was 
> another underlying root cause that should also be addressed. There was an 
> INodeReference that was deleted and the lease on it was not subsequently 
> deleted because it was never added to the reclaim context.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to