[ 
https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052297#comment-13052297
 ] 

Jitendra Nath Pandey commented on HDFS-2086:
--------------------------------------------

1. inHostsList and inExcludeHostsList do same things on two different lists. 
Both can use a single method that also takes the list as argument.
2. Do we really need to look into hostsList for both node.getName and 
iaddr.getHostName? I understand node.getName may actually be returning the 
ip:port, but for IP iaddr.getHostAddress is more reliable. Caveat with the 
later approach: Can we assume ipAddr and node (DatanodeID) will always be for 
the same host?

Minor: Indentation in checkIncludeListForDead.

> If the include hosts list contains host name, after restarting namenode, 
> datanodes registrant is denied 
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-2086
>                 URL: https://issues.apache.org/jira/browse/HDFS-2086
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Tanping Wang
>            Assignee: Tanping Wang
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2086.patch
>
>
> As the title describes the problem:  if the include host list contains host 
> name, after restarting namenodes, the datanodes registrant is denied by 
> namenodes.  This is because after namenode is restarted, the still alive data 
> node will try to register itself with the namenode and it identifies itself 
> with its *IP address*.  However, namenode only allows all the hosts in its 
> hosts list to registrant and all of them are hostnames. So namenode would 
> deny the datanode registration.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to