[ 
https://issues.apache.org/jira/browse/HDFS-13119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364497#comment-16364497
 ] 

Íñigo Goiri commented on HDFS-13119:
------------------------------------

[~linyiqun], yep the retry logic kind of break the flow.
Anyway, I think we should try to refactor that part of code and avoid repeating 
this:
{code:java}
if (this.rpcMonitor != null) {
  this.rpcMonitor.proxyOpRetries();
}
return invoke(nsId, ++retryCount, method, obj, params);
{code}
It's minor but I think that we should try to make an effort to keep this 
function as easy to read as possible.
What about extending {{shouldRetry()}} and check for unavailable there?
We already use the FAIL case there but maybe we can just throw the exception 
there.


> RBF: Manage unavailable clusters
> --------------------------------
>
>                 Key: HDFS-13119
>                 URL: https://issues.apache.org/jira/browse/HDFS-13119
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Yiqun Lin
>            Priority: Major
>         Attachments: HDFS-13119.001.patch, HDFS-13119.002.patch, 
> HDFS-13119.003.patch
>
>
> When a federated cluster has one of the subcluster down, operations that run 
> in every subcluster ({{RouterRpcClient#invokeAll()}}) may take all the RPC 
> connections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to