Anu Engineer commented on HDFS-11699:

[~elek] Thanks for the code review comments. The patch v2 addresses all 
comments and fixes the checkStyle issues too.

Details below:
bq.  In ContainerMapping.java/processContainerReport: I don't undestand the 
comments, but my impression is that the two method should be swaped:
You are absolutely right; thanks for catching that.

bq. According to my understanding this code will send a close command even if 
the container is in CLOSED state. IMHO it should be sent only if the container 
in OPEN or CLOSING state.


bq.  It's not clear for me how the CLOSED state will be achieved, but maybe 
it's a task of a different jira.
Correct, the client will post that message. I think we have a JIRA in progress 
for that already.

bq. javadoc of ContainerMapping.shouldClose is misleading. It returns false if 
the container is closed

> Ozone:SCM: Add support for close containers in SCM
> --------------------------------------------------
>                 Key: HDFS-11699
>                 URL: https://issues.apache.org/jira/browse/HDFS-11699
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>            Priority: Major
>         Attachments: HDFS-11699-HDFS-7240.001.patch, 
> HDFS-11699-HDFS-7240.002.patch
> Add support for closed containers in SCM. When a container is closed, SCM 
> needs to make a set of decisions like which pool and which machines are 
> expected to have this container. SCM also needs to issue a copyContainer 
> command to the target datanodes so that these nodes can replicate data from 
> the original locations.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to