[
https://issues.apache.org/jira/browse/HDFS-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052650#comment-13052650
]
Eli Collins commented on HDFS-2074:
-----------------------------------
+1 looks great
Nits:
- javadoc for validateEditLog says it throws an IOException if it can't read
the file, slightly misleading since it eg returns EditLogValidation(0,0) if it
can't read the header
- TestFSEditLogLoader still has loglevel ALL
> 1073: determine edit log validity by truly reading and validating transactions
> ------------------------------------------------------------------------------
>
> Key: HDFS-2074
> URL: https://issues.apache.org/jira/browse/HDFS-2074
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-2074.txt
>
>
> HDFS-2003 separated the deserialization/reading of log records from the
> application of those records to a namesystem. This means that we can now read
> through an edit log in order to determine how many valid transactions are
> actually stored within. This is an improvement on what the 1073 branch
> currently does, which is to simply look at how many bytes come before the
> 0xFFFF... trailer at the end of the file.
> The next step after this is to use these new functions so that, when the NN
> starts up and finds "in-progress" files like "edits_2_inprogress", it will
> rename them to their finalized name like "edits_2-30" based on how many
> transactions are truly stored within. This will simplify logic elsewhere.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
