Íñigo Goiri commented on HDFS-13168:

Thanks [~belugabehr] for the results, the performance improvements are nothing 
spectacular but as I said, I think it makes sense.
The memory fragmentation is obviously there now, so that's another plus.

[^HDFS-13168.2.patch] now keeps {{element.toString()}}, is this intentional? I 
think what you had in  [^HDFS-13168.1.patch] made more sense there.

> XmlImageVisitor - Prefer Array over LinkedList
> ----------------------------------------------
>                 Key: HDFS-13168
>                 URL: https://issues.apache.org/jira/browse/HDFS-13168
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HDFS-13168.1.patch, HDFS-13168.2.patch
> {{ArrayDeque}}
> {quote}This class is likely to be faster than Stack when used as a stack, and 
> faster than LinkedList when used as a queue.{quote}
> .. not to mention less memory fragmentation (single backing array v.s. many 
> ArrayList nodes).
> https://docs.oracle.com/javase/8/docs/api/java/util/ArrayDeque.html

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to