[ 
https://issues.apache.org/jira/browse/HDFS-13119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369410#comment-16369410
 ] 

Íñigo Goiri commented on HDFS-13119:
------------------------------------

Thanks [~linyiqun].

bq. RejectedExecutionException won't be thrown when we hit the maximum number 
of threads I think. Inside Executors#newFixedThreadPool, it uses the 
Integer.MAX_VALUE capacity of LinkedBlockingQueue for storing pending task. So 
it will wait in the queue until a thread is available.

Just to keep the full discussion clear in the JIRA, the behavior will be that 
the incoming RPC queries will be stuck in the queue until we have free Router 
RPC Client threads. I think this together with the maximum of 1 retry makes 
sense.

One minor comment on  [^HDFS-13119.005.patch], we should update the javadoc 
comment in {{shouldRetry()}} for when {{IOException}} is thrown.
+1.

> RBF: Manage unavailable clusters
> --------------------------------
>
>                 Key: HDFS-13119
>                 URL: https://issues.apache.org/jira/browse/HDFS-13119
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Yiqun Lin
>            Priority: Major
>         Attachments: HDFS-13119.001.patch, HDFS-13119.002.patch, 
> HDFS-13119.003.patch, HDFS-13119.004.patch, HDFS-13119.005.patch
>
>
> When a federated cluster has one of the subcluster down, operations that run 
> in every subcluster ({{RouterRpcClient#invokeAll()}}) may take all the RPC 
> connections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to