[ 
https://issues.apache.org/jira/browse/HDFS-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372254#comment-16372254
 ] 

Arpit Agarwal commented on HDFS-12865:
--------------------------------------

Hi [~msingh], The patch looks good. Minor suggestion - can you expand the error 
message a bit? e.g. _No valid proxies left. All NameNode proxies have failed 
over._

Also in the test case, it may be better to generate a random hostname here:
{code}
            DFS_NAMENODE_RPC_ADDRESS_KEY + "." + singleNS + ".nn1",
        "machine1.foo.bar:9820");
{code}

> RequestHedgingProxyProvider should handle case when none of the proxies are 
> available
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-12865
>                 URL: https://issues.apache.org/jira/browse/HDFS-12865
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>            Priority: Major
>         Attachments: HDFS-12865.001.patch, HDFS-12865.002.patch
>
>
> RequestHedgingProxyProvider when all the targets have failover'ed will throw 
> a MultiException as expected. But this MultiException will not have the 
> corresponding lower level exceptions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to