[
https://issues.apache.org/jira/browse/HDFS-13162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372802#comment-16372802
]
Nanda kumar commented on HDFS-13162:
------------------------------------
Thanks Bharat for updating the patch. Patch looks good to me.
Some minor comment in the test-cases; Sorry for missing it in the previous
review comment.
* In {{TestDataStorage#testReplicaTrashDirectory}} we can remove line:159
{{assertTrue(replicaTrashDir.exists())}} as {{isDirectory}} call also checks
for the existance of directory.
* In {{TestDataStorage#testReplicaTrashDirectory}} we can remove line:181,
checking {{assertFalse(replicaTrashDir.exists())}} should be sufficient.
The checkstyle issues on line length in StorageLocation: Line 235 & 236
> Create Replica Trash directory on DN startup
> --------------------------------------------
>
> Key: HDFS-13162
> URL: https://issues.apache.org/jira/browse/HDFS-13162
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDFS-13162-HDFS-12996.01.patch,
> HDFS-13162-HDFS-12996.02.patch, HDFS-13162.00-HDFS-12996.00.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
