[
https://issues.apache.org/jira/browse/HDFS-13178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373392#comment-16373392
]
Arpit Agarwal edited comment on HDFS-13178 at 2/22/18 8:32 PM:
---------------------------------------------------------------
Thanks for the patch [~bharatviswa]. Minor comment:
# This can be simplified from
{code}
+ if(cmd.hasOption(DiskBalancerCLI.FORCE)) {
+ submitPlan(planFile, planData, true);
+ } else {
+ submitPlan(planFile, planData, false);
+ }
{code}
to
{code}
submitPlan(planFile, planData, cmd.hasOption(DiskBalancerCLI.FORCE))
{code}
I think it's better to call the command line option {{skipDateCheck}} since it
clearly describes the purpose of the flag, but am okay with force also.
Is it possible to add a new test case to verify the force functionality?
cc [~anu].
was (Author: arpitagarwal):
Thanks for the patch [~bharatviswa]. Minor comment:
# This can be simplified fro,
{code}
+ if(cmd.hasOption(DiskBalancerCLI.FORCE)) {
+ submitPlan(planFile, planData, true);
+ } else {
+ submitPlan(planFile, planData, false);
+ }
{code}
to
{code}
submitPlan(planFile, planData, cmd.hasOption(DiskBalancerCLI.FORCE))
{code}
I think it's better to call the command line option {{skipDateCheck}} since it
clearly describes the purpose of the flag, but am okay with force also.
Is it possible to add a new test case to verify the force functionality?
cc [~anu].
> Add a force option to DiskBalancer Execute command
> --------------------------------------------------
>
> Key: HDFS-13178
> URL: https://issues.apache.org/jira/browse/HDFS-13178
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: diskbalancer
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDFS-13178.00.patch
>
>
>
> Add a force option to DiskBalancer Execute command, which is used for skip
> date check and force execute the plan.
> This is one of the TODO for diskbalancer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
