[
https://issues.apache.org/jira/browse/HDFS-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052890#comment-13052890
]
Todd Lipcon commented on HDFS-2100:
-----------------------------------
Looks pretty good, nice test. A few comments:
- Seems like you got distracted halfway through writing this comment:
{code}
// The created file should still exist in the
{code}
- You might consider using {{ImmutableSet.of(path1)}} and
{{ImmutableSet.of(path2, path3)}} from guava - it's a bit easier to read IMO
but no biggy
- Can you add a javadoc to explain what bug this is testing for and what the
simulation is? Seems funny that the test case is called
testMultipleSecondasryCheckpoint but it only instantiates one 2NN.
> Improve TestStorageRestore
> --------------------------
>
> Key: HDFS-2100
> URL: https://issues.apache.org/jira/browse/HDFS-2100
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-2100.0.patch
>
>
> Though running multiple 2NNs isn't supported, accidentally doing so should
> not result in HDFS metadata corruptions. We should add a test case to
> exercise this possibility when name.dir.storage.restore is enabled, which is
> a particularly delicate code path.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
