[ 
https://issues.apache.org/jira/browse/HDFS-13008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374793#comment-16374793
 ] 

Xiaoyu Yao commented on HDFS-13008:
-----------------------------------

Thanks [~nandakumar131] for the review.

bq. ContainerData.java: containerID can be made as a final field and the 
corresponding setter method can be removed.
The setter is used by ContainerData#getFromProtBuf. 

bq. TestContainerReportWithKeys.java: Why not use OzoneClient instead of 
ObjectStoreHandler?
Good catch. I've updated the patch to use OzoneClient.

> Ozone: Add DN container open/close state to container report
> ------------------------------------------------------------
>
>                 Key: HDFS-13008
>                 URL: https://issues.apache.org/jira/browse/HDFS-13008
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7240
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>            Priority: Major
>         Attachments: HDFS-13008-HDFS-7240.001.patch, 
> HDFS-13008-HDFS-7240.002.patch, HDFS-13008-HDFS-7240.003.patch
>
>
> HDFS-12799 added support to allow SCM send closeContainerCommand to DNs. This 
> ticket is opened to add the DN container close state to container report so 
> that SCM container state manager can update state from closing to closed when 
> DN side container is fully closed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to