[ 
https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375251#comment-16375251
 ] 

Yiqun Lin commented on HDFS-13184:
----------------------------------

{quote}Regarding HDFS-13184.001.patch, it seems a little anti intuitive for it 
to be a namenode override when it's the Router client doing this. Shouldn't 
this be a setting for the Router itself?
{quote}
Seems making these client settings into Router conf, it won't make sense. The 
Router conf is used for building {{RouterContext}} in UT.
 I create a new client settings and override them in startcluster. Hope this 
way makes sense to you, [~elgoiri].

Attach the updated patch.

> RBF: Improve the unit test TestRouterRPCClientRetries
> -----------------------------------------------------
>
>                 Key: HDFS-13184
>                 URL: https://issues.apache.org/jira/browse/HDFS-13184
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>            Priority: Minor
>         Attachments: HDFS-13184.001.patch, HDFS-13184.002.patch
>
>
> From the proposal in this 
> https://issues.apache.org/jira/browse/HDFS-13119?focusedCommentId=16370421&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16370421,
>   this will speed the test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to