[ https://issues.apache.org/jira/browse/HDFS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376194#comment-16376194 ]
Íñigo Goiri commented on HDFS-13192: ------------------------------------ [^HDFS-13192.001.patch] LGTM and it makes sense to avoid those operations. I've been trying to check which unit tests would cover this case but I'm not super familiar with this part. Could you point to the related unit tests? I'd like to double check that they were executed successfully by Yetus. > change the code order in getFileEncryptionInfo to avoid unnecessary call of > assignment > -------------------------------------------------------------------------------------- > > Key: HDFS-13192 > URL: https://issues.apache.org/jira/browse/HDFS-13192 > Project: Hadoop HDFS > Issue Type: Improvement > Components: encryption > Affects Versions: 3.1.0 > Reporter: LiXin Ge > Assignee: LiXin Ge > Priority: Minor > Attachments: HDFS-13192.001.patch > > > The assignment of {{version,suite}} and {{keyName}} should happen lazily, > right before it's used in case the {{fileXAttr}} is *null* -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org