[ 
https://issues.apache.org/jira/browse/HDFS-13188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377827#comment-16377827
 ] 

Íñigo Goiri commented on HDFS-13188:
------------------------------------

bq. Just want to ask, we have line limit length to 80, is there any requirement 
that if it is less than 80, we should fit it in a single line?

No requirement but I personally think it's good practice to keep the code as 
clean as possible.
Obviously there are plenty of exceptions and Yetus doesn't even mark it as 
checkstyle warning.

The unit tests are good in my opinion; I'll wait for Yetus just in case.
+1 on  [^HDFS-13188.05.patch].
If nobody has issues I'll commit this.

> Disk Balancer: Support multiple block pools during block move
> -------------------------------------------------------------
>
>                 Key: HDFS-13188
>                 URL: https://issues.apache.org/jira/browse/HDFS-13188
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: diskbalancer
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>         Attachments: HDFS-13188.01.patch, HDFS-13188.02.patch, 
> HDFS-13188.03.patch, HDFS-13188.04.patch, HDFS-13188.05.patch
>
>
> During execute plan:
> *Federated setup:*
> When multiple block pools are there, it will only copy from blocks from first 
> block pool to destination disk, when balancing.
> We want to distribute the blocks from all block pools on source disk to 
> destination disk during balancing.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to