[ 
https://issues.apache.org/jira/browse/HDFS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053096#comment-13053096
 ] 

Aaron T. Myers commented on HDFS-266:
-------------------------------------

bq. the marginal benefit of making this a singleton doesn't fix what ails this 
class.

Can we close this issue then?

> JspHelper should be a singleton
> -------------------------------
>
>                 Key: HDFS-266
>                 URL: https://issues.apache.org/jira/browse/HDFS-266
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: 4600-0.patch
>
>
> Servlets creating JspHelper instances initialize a set of statics and use the 
> empty instance as a handle to class methods. Instead, JspHelper should either 
> be a singleton with instance fields or its methods should also be static.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to