[
https://issues.apache.org/jira/browse/HDFS-13176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386917#comment-16386917
]
Sean Mackrory edited comment on HDFS-13176 at 3/5/18 11:15 PM:
---------------------------------------------------------------
At first glance, I love that this is addressing URL-specific weirdness in
WebHDFS specifically and isn't modifying Path for the whole world. I'll do a
deeper code review and make sure I do agree with everything, but I strongly
suspect this is indeed the right way to solve this.
One of the outcomes of this Jira I'd love to see is that we do finally clarify
which paths are legal paths. ?, %, and \ make me nervous for the potential for
them to be misinterpreted by related tools or future classes because of their
role in URLs and Windows paths (which is exactly why : wouldn't work). There
are a few other characters that I would personally avoid because of their role
in scripts (I would have similar concerns about ~, *, `, @, !, $), etc, but I'd
feel more comfortable agreeing to support the following subset of what you're
currently testing: \"()[]_-=&+;{}#. Anyone else have thoughts along these lines?
was (Author: mackrorysd):
At first glance, I love that this is addressing URL-specific weirdness in
WebHDFS specifically and isn't modifying Path for the whole world. I'll do a
deeper code review and make sure I do agree with everything, but I strongly
suspect this is indeed the right way to solve this.
One of the outcomes of this Jira I'd love to see is that we do finally clarify
which paths are legal paths. ?, %, and \\ make me nervous for the potential for
them to be misinterpreted by related tools or future classes because of their
role in URLs and Windows paths (which is exactly why : wouldn't work). There
are a few other characters that I would personally avoid because of their role
in scripts (I would have similar concerns about ~, *, `, @, !, $), etc, but I'd
feel more comfortable agreeing to support the following subset of what you're
currently testing: \"()[]_-=&+;{}#. Anyone else have thoughts along these lines?
> WebHdfs file path gets truncated when having semicolon (;) inside
> -----------------------------------------------------------------
>
> Key: HDFS-13176
> URL: https://issues.apache.org/jira/browse/HDFS-13176
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: webhdfs
> Affects Versions: 3.0.0
> Reporter: Zsolt Venczel
> Assignee: Zsolt Venczel
> Priority: Major
> Attachments: HDFS-13176.01.patch,
> TestWebHdfsUrl.testWebHdfsSpecialCharacterFile.patch
>
>
> Find attached a patch having a test case that tries to reproduce the problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
