Tsz Wo Nicholas Sze updated HDFS-13223:
    Hadoop Flags: Reviewed

+1 patch looks good.

There is a LineLength checkstyle warning in TestDiffListBySkipList.   Since it 
is very minor, I will just fix it before committing the patch.

> Reduce DiffListBySkipList memory usage
> --------------------------------------
>                 Key: HDFS-13223
>                 URL: https://issues.apache.org/jira/browse/HDFS-13223
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: snapshots
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Shashikant Banerjee
>            Priority: Major
>         Attachments: HDFS-13223.001.patch, HDFS-13223.002.patch, 
> HDFS-13223.003.patch, HDFS-13223.004.patch
> There are several ways to reduce memory footprint of DiffListBySkipList.
> - Move maxSkipLevels and skipInterval to DirectoryDiffListFactory.
> - Use an array for skipDiffList instead of List.
> - Do not store the level 0 element in skipDiffList.
> - Do not create new ChildrenDiff for the same value.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to