[ https://issues.apache.org/jira/browse/HDFS-13212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389833#comment-16389833 ]
Íñigo Goiri commented on HDFS-13212: ------------------------------------ Thanks [~wuweiwei] for the detailed explanation, that makes sense. In the unit test, we may want to add an assert to check that we get the default location for: {code} // Add the default location to location cache mountTable.getDestinationForPath("/testlocationcache"); {code} Other than that, in [^HDFS-13212-005.patch], there are a couple check style issues with the line length. Then {TestRouterQuota} is failing now, it actually might be related; do you mind checking? > RBF: Fix router location cache issue > ------------------------------------ > > Key: HDFS-13212 > URL: https://issues.apache.org/jira/browse/HDFS-13212 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: federation, hdfs > Reporter: Weiwei Wu > Priority: Major > Attachments: HDFS-13212-001.patch, HDFS-13212-002.patch, > HDFS-13212-003.patch, HDFS-13212-004.patch, HDFS-13212-005.patch > > > The MountTableResolver refreshEntries function have a bug when add a new > mount table entry which already have location cache. The old location cache > will never be invalid until this mount point change again. > Need to invalid the location cache when add the mount table entries. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org