[ 
https://issues.apache.org/jira/browse/HDFS-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390398#comment-16390398
 ] 

Chao Sun commented on HDFS-13230:
---------------------------------

Attaching patch v0. Found that I need to change a few places in the original 
code to make it testable. Let me know if you have any suggestion.

Also, in the {{cleanup}} method, why we only remove 1 connection every time? 
also, it seems {{removeConnection}} will just pick the last connection to 
close, without considering whether it is closed or active, is there any reason 
for this?

> RBF: ConnectionManager's cleanup task will compare each pool's own active 
> conns with its total conns
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13230
>                 URL: https://issues.apache.org/jira/browse/HDFS-13230
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Wei Yan
>            Assignee: Chao Sun
>            Priority: Minor
>         Attachments: HDFS-13230.000.patch
>
>
> In the cleanup task:
> {code:java}
> long timeSinceLastActive = Time.now() - pool.getLastActiveTime();
> int total = pool.getNumConnections();
> int active = getNumActiveConnections();
> if (timeSinceLastActive > connectionCleanupPeriodMs ||
> {code}
> the 3rd line should be pool.getNumActiveConnections()
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to