[ 
https://issues.apache.org/jira/browse/HDFS-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392142#comment-16392142
 ] 

Xiao Chen commented on HDFS-13239:
----------------------------------

Thanks [~hanishakoneru] for reporting the issue and [~bharatviswa] for fixing 
it.

I don't think the fix is correct though. The configuration is a NN property, so 
even though we can read it in ECAdmin, there is no way we can guarantee its 
value is the same as the NN.

Instead of printing out the default policy name, how about we just literally 
say 'the default erasure coding policy' in the message?

> Fix non-empty dir warning message when setting default EC policy
> ----------------------------------------------------------------
>
>                 Key: HDFS-13239
>                 URL: https://issues.apache.org/jira/browse/HDFS-13239
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Hanisha Koneru
>            Assignee: Bharat Viswanadham
>            Priority: Minor
>         Attachments: HDFS-13239.00.patch, HDFS-13239.01.patch
>
>
> When EC policy is set on a non-empty directory, the following warning message 
> is given:
> {code}
> $hdfs ec -setPolicy -policy RS-6-3-1024k -path /ec1
> Warning: setting erasure coding policy on a non-empty directory will not 
> automatically convert existing files to RS-6-3-1024k
> {code}
> When we do not specify the -policy parameter when setting EC policy on a 
> directory, it takes the default EC policy. Setting default EC policy in this 
> way on a non-empty directory gives the following warning message:
> {code}
> $hdfs ec -setPolicy -path /ec2
> Warning: setting erasure coding policy on a non-empty directory will not 
> automatically convert existing files to null
> {code}
> Notice that the warning message in the 2nd case has the ecPolicy name shown 
> as null. We should instead give the default EC policy name in this message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to