[
https://issues.apache.org/jira/browse/HDFS-11600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394916#comment-16394916
]
SammiChen edited comment on HDFS-11600 at 3/12/18 8:37 AM:
-----------------------------------------------------------
Hi [~rakeshr], thanks for the comments.
bq. 2. I hope you have named the class with "P" to represent parameterized
class. Can we give a meaningful name instead of appending with letter "P" -
TestDFSStripedOutputStreamWithFailureP,
TestDFSStripedOutputStreamWithFailurePWithRandomECPolicy.
Regarding the class name with "P", you are right, it stands for
"parameterized". I was originally using the full word, then found out the
class name becomes very very long, especially
"TestDFSStripedOutputStreamWithFailureWithRandomECPolicy".
bq.
4.TestDFSStripedOutputStreamWithFailureBase#testCloseWithExceptionsInStreamer
function is not used anywhere. Whats the purpose of this?
testCloseWithExceptionsInStreamer is both
TestDFSStripedOutputStreamWithFailureBase and
TestDFSStripedOutputStreamWithFailure. I will remove it from
TestDFSStripedOutputStreamWithFailureBase.
Will soon upload a new patch.
was (Author: sammi):
Hi [~rakeshr], thanks for the comments. I will upload a new patch to address
all the issues. Regarding the class name with "P", you are right, it stands for
"parameterized". I was originally using the full word, then found out the
class name becomes very very long, especially
"TestDFSStripedOutputStreamWithFailureWithRandomECPolicy".
> Refactor TestDFSStripedOutputStreamWithFailure test classes
> -----------------------------------------------------------
>
> Key: HDFS-11600
> URL: https://issues.apache.org/jira/browse/HDFS-11600
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0-alpha2
> Reporter: Andrew Wang
> Priority: Minor
> Attachments: HDFS-11600-1.patch, HDFS-11600.002.patch,
> HDFS-11600.003.patch, HDFS-11600.004.patch
>
>
> TestDFSStripedOutputStreamWithFailure has a great number of subclasses. The
> tests are parameterized based on the name of these subclasses.
> Seems like we could parameterize these tests with JUnit and then not need all
> these separate test classes.
> Another note, the tests will randomly return instead of running the test.
> Using {{Assume}} instead would make it more clear in the test output that
> these tests were skipped.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
