[
https://issues.apache.org/jira/browse/HDFS-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395649#comment-16395649
]
Xiaoyu Yao commented on HDFS-13261:
-----------------------------------
[~jiangjianfei] , patch looks good to me.
Can you add some informative error message as the second parameter of
checkNotNull()?
{code}
e.g., Preconditions.checkNotNull(name, "zone name cannot be null");
{code}
> Incorrect null value check
> --------------------------
>
> Key: HDFS-13261
> URL: https://issues.apache.org/jira/browse/HDFS-13261
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Affects Versions: 2.8.3, 3.0.0
> Reporter: Jianfei Jiang
> Assignee: Jianfei Jiang
> Priority: Minor
> Attachments: HDFS-13261.001.patch
>
>
>
> {code:java}
> public void setZoneName(final String name) {
> Preconditions.checkNotNull(name == null)-------error parameter for
> checkNotNull
> zoneName = name;
> }
> {code}
> Like above, in 3.x, the checkNotNull function gets wrong parameter in two
> cases: \{{ZoneReencryptionStatus#setZoneName}} and
> \{{AdminHelper#HelpCommand#HelpCommand}}
> In 2.x, the error occurs once in \{{AdminHelper#HelpCommand#HelpCommand}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
