[ 
https://issues.apache.org/jira/browse/HDFS-11399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395694#comment-16395694
 ] 

Íñigo Goiri commented on HDFS-11399:
------------------------------------

HADOOP-9427 is missing in 2.X.
I reverted those commits and I'll add a branch-2 patch using Shell.WINDOWS.

> Many tests fails in Windows due to injecting disk failures
> ----------------------------------------------------------
>
>                 Key: HDFS-11399
>                 URL: https://issues.apache.org/jira/browse/HDFS-11399
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>            Priority: Major
>             Fix For: 3.1.0, 2.10.0, 2.9.1, 3.0.2, 3.2.0
>
>         Attachments: HDFS-11399.001.patch, HDFS-11399.002.patch
>
>
> Found many tests run failed in Windows due to using 
> {{DataNodeTestUtils#injectDataDirFailure}}. One of the failure test:
> {code}
> java.io.IOException: Failed to rename 
> D:\work-project\hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\data\data2
>  to 
> D:\work-project\hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\data\data2.origin.
>       at 
> org.apache.hadoop.hdfs.server.datanode.DataNodeTestUtils.injectDataDirFailure(DataNodeTestUtils.java:156)
>       at 
> org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean.testStorageTypeStatsWhenStorageFailed(TestBlockStatsMXBean.java:176)
> {code}
> The root cause of this is that the test method uses 
> {{DataNodeTestUtils#injectDataDirFailure}} to injects disk failures but 
> however missing the compare operation {{assumeNotWindows}}. Currently 
> {{DataNodeTestUtils#injectDataDirFailure}} is not supported in Windows then 
> the test fails.
> It would be better to add {{assumeNotWindows}} into 
> {{DataNodeTestUtils#injectDataDirFailure}} in case we forget to add this in 
> test methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to