[ 
https://issues.apache.org/jira/browse/HDFS-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395761#comment-16395761
 ] 

Tsz Wo Nicholas Sze commented on HDFS-6853:
-------------------------------------------

> It might make sense to fix isNameNodeUp() instead.

If NN == null, NN is not up.  So isNameNodeUp() seems fine.  But as long as one 
NN is up,  isClusterUp() should return true.  So the bug is in isClusterUp().

For the .2 patch, it looks good except that it returns true if all NNs are null.

[~james.thomas], would you mind updating the patch?



> MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
> ----------------------------------------------------------------------
>
>                 Key: HDFS-6853
>                 URL: https://issues.apache.org/jira/browse/HDFS-6853
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: James Thomas
>            Assignee: James Thomas
>            Priority: Major
>         Attachments: HDFS-6853.2.patch, HDFS-6853.patch
>
>
> Suppose we have a two-NN cluster and then shut down one of the NN's (NN0). 
> When we try to restart the other NN (NN1), we wait for isClusterUp() to 
> return true, but this will never happen because NN0 is null and isNameNodeUp 
> returns false for a null NN.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to