[ 
https://issues.apache.org/jira/browse/HDFS-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395763#comment-16395763
 ] 

Xiao Chen commented on HDFS-12587:
----------------------------------

Thanks [~tasanuma0829] for reporting and working on this. I agree parameterize 
these tests is a good idea since it runs pretty fast.

Could you extract the parameter setup code to a utility method, to reduce code 
duplication? {{StripedFileTestUtil}} has some existing methods like 
{{getRandomNonDefaultECPolicy}}, maybe we can add there.

> Use Parameterized tests in TestBlockInfoStriped and 
> TestLowRedundancyBlockQueues to apply multiple EC policies
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12587
>                 URL: https://issues.apache.org/jira/browse/HDFS-12587
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding, test
>            Reporter: Takanobu Asanuma
>            Assignee: Takanobu Asanuma
>            Priority: Major
>              Labels: hdfs-ec-3.0-nice-to-have
>         Attachments: HDFS-12587.1.patch
>
>
> This is a subtask of HDFS-9962. Since {{TestBlockInfoStriped}} and 
> {{TestLowRedundancyBlockQueues}} don't use minicluster, testing all ec 
> policies with Parameterized tests in each time is not a big impact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to