[ 
https://issues.apache.org/jira/browse/HDFS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395836#comment-16395836
 ] 

Wei Yan commented on HDFS-12773:
--------------------------------

{noformat}
It looks to me like a very particular implementation detail.
{noformat}
Make sense.
 [^HDFS-12773.004.patch] LGTM. One minor:
{code:java|title=StateStoreFileImpl.java}
LOG.error("The root directory is not available, using {}", dir); {code}
Here would better be "LOG.warn()", as the process still proceeds.

> RBF: Improve State Store FS implementation
> ------------------------------------------
>
>                 Key: HDFS-12773
>                 URL: https://issues.apache.org/jira/browse/HDFS-12773
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Major
>         Attachments: HDFS-12773.000.patch, HDFS-12773.001.patch, 
> HDFS-12773.002.patch, HDFS-12773.003.patch, HDFS-12773.004.patch
>
>
> HDFS-10630 introduced a filesystem implementation of the State Store for unit 
> tests. However, this implementation doesn't handle multiple writers 
> concurrently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to