[ 
https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397689#comment-16397689
 ] 

Ajay Kumar commented on HDFS-13251:
-----------------------------------

Patch v3 to adress [~xyao] suggestions.
Removed below changes as suggested :
* TestDataNodeHotSwapVolumes.java Line 698/715/716 
* TestDataNodeVolumeFailureReporting Line 81/780
* TestDataNodeVolumeFailureToleration#testValidVolumesAtStartup() 
* TestDFSAdmin#testDataNodeGetReconfigurationStatus() 


> Avoid using hard coded datanode data dirs in unit tests
> -------------------------------------------------------
>
>                 Key: HDFS-13251
>                 URL: https://issues.apache.org/jira/browse/HDFS-13251
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Xiaoyu Yao
>            Assignee: Ajay Kumar
>            Priority: Major
>         Attachments: HDFS-13251.000.patch, HDFS-13251.001.patch, 
> HDFS-13251.002.patch, HDFS-13251.003.patch
>
>
> There are a few unit tests that rely on hard-coded MiniDFSCluster data dir 
> names.
>  
>  * TestDataNodeVolumeFailureToleration
>  * TestDataNodeVolumeFailureReporting
>  * TestDiskBalancerCommand
>  * TestBlockStatsMXBean
>  * TestDataNodeVolumeMetrics
>  * TestDFSAdmin
>  * TestDataNodeHotSwapVolumes
>  * TestDataNodeVolumeFailure
> This ticket is opened to use
> {code:java}
> MiniDFSCluster#getInstanceStorageDir(0, 1);
> instead of like below
> new File(cluster.getDataDirectory(), "data1");{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to