[
https://issues.apache.org/jira/browse/HDFS-13163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398664#comment-16398664
]
Arpit Agarwal commented on HDFS-13163:
--------------------------------------
Thanks [~bharatviswa]. Very minor comments:
# FsDatasetAsyncDiskService#replicaTrashEnabled and conf can be final.
# replicaTrashDirectory and replicaTrashDir are slightly confusing names. You
could rename replicaTrashDirectory to replicaTrashBaseDir.
+1 with these two addressed.
Let's try to replace the UT with an isolated unit test for
ReplicaFileDeleteTask#run that doesn't spin up a MiniDfsCluster. Okay to do
this in a separate Jira.
> Move invalidated blocks to replica-trash with disk layout based on timestamp
> ----------------------------------------------------------------------------
>
> Key: HDFS-13163
> URL: https://issues.apache.org/jira/browse/HDFS-13163
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDFS-13163-HDFS-12996.00.patch,
> HDFS-13163-HDFS-12996.01.patch, HDFS-13163-HDFS-12996.02.patch
>
>
> When Blocks are invalidated, move the blocks to replica-trash directory and
> place it in the folder when the invalidate is received from the namenode
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
