[
https://issues.apache.org/jira/browse/HDFS-13250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400058#comment-16400058
]
Yiqun Lin commented on HDFS-13250:
----------------------------------
[~elgoiri], the patch almost looks good, just some minor comments:
*RouterRpcServer.java*:
line1146. Method {{getFileInfoAll}} won't return first FileStatus info even if
there are files existed. We need to do additional check of
{{fileStatus.isFile()}} and remember the first FileStatus info in following
loop. Finally returns that one in the end of the method.
{code:java}
for (HdfsFileStatus fileStatus : results.values()) {
if (fileStatus != null && fileStatus.isDir()) {
numDirs++;
}
}
{code}
line587. Can we add the check {{isPathAll(src)}} in {{append}} RPC call as
well? It will be frequently invoked when writing file data.
line2177: {{isMountTableEntryAll}} should also return true if given order is
{{RANDOM}}.
*TestRouterHashResolver.java*
line101: Can we just to trigger the cache load rather than waiting for this?
The javadoc of this method also looks confused. It is said {{Wait until the
mount table entry is available in all the routers.}}, but actually it only
checks a random one Router.
> RBF: Router to manage requests across multiple subclusters
> ----------------------------------------------------------
>
> Key: HDFS-13250
> URL: https://issues.apache.org/jira/browse/HDFS-13250
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-13250.000.patch, HDFS-13250.001.patch
>
>
> HDFS-13124 introduces the concept of mount points spanning multiple
> subclusters. The Router should distribute the requests across these
> subclusters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
