[ 
https://issues.apache.org/jira/browse/HDFS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054745#comment-13054745
 ] 

Hadoop QA commented on HDFS-1381:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12483782/HDFS-1381-take1.txt
  against trunk revision 1139397.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/834//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HDFS-Build/834//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/834//console

This message is automatically generated.

> MiniDFSCluster documentation refers to out-of-date configuration parameters
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-1381
>                 URL: https://issues.apache.org/jira/browse/HDFS-1381
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.20.1
>            Reporter: Jakob Homan
>            Assignee: Jim Plush
>              Labels: newbie
>             Fix For: 0.23.0
>
>         Attachments: HDFS-1381-take1.txt
>
>
> The javadoc for MiniDFSCluster makes repeated references to setting 
> dfs.name.dir and dfs.data.dir.  These should be replaced with references to 
> DFSConfigKeys' DFS_NAMENODE_NAME_DIR_KEY and DFS_DATANODE_DATA_DIR_KEY, 
> respectively.  The old values are deprecated in DFSConfigKeys, but we should 
> switch to the new values where ever we can.
> Also, a quick search the code shows that TestDFSStorageStateRecovery.java and 
> UpgradeUtilities.java should be updated as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to