[
https://issues.apache.org/jira/browse/HDFS-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404495#comment-16404495
]
LiXin Ge commented on HDFS-13087:
---------------------------------
Thanks [~xiaochen] for reviewing this again.
{quote}I think we should go with the default Enum#equals comparison
{quote}
Yes, I'm done, use {{EqualsBuilder}} Instead of the new added {{isEqual}} now.
{quote}We can use HashCodeBuilder and EqualsBuilder to implement the EZI equals
method.
{quote}
Done in the new attached patch.
{quote}EZI#getEncryptionZoneForPath: can we still use the existing logic to get
from encryptionZones?
{quote}
Good idea, done.
{quote}In the new method, parameter name typo 'sanpshotId'.
{quote}
Done, sorry for the typo, and thanks for your carefully review.
> Fix: Snapshots On encryption zones get incorrect EZ settings when encryption
> zone changes
> -----------------------------------------------------------------------------------------
>
> Key: HDFS-13087
> URL: https://issues.apache.org/jira/browse/HDFS-13087
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: encryption
> Affects Versions: 3.1.0
> Reporter: LiXin Ge
> Assignee: LiXin Ge
> Priority: Major
> Attachments: HDFS-13087.001.patch, HDFS-13087.002.patch,
> HDFS-13087.003.patch, HDFS-13087.004.patch
>
>
> Snapshots are supposed to be immutable and read only, so the EZ settings
> which in a snapshot path shouldn't change when the origin encryption zone
> changes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
