[ 
https://issues.apache.org/jira/browse/HDFS-13314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405451#comment-16405451
 ] 

Arpit Agarwal commented on HDFS-13314:
--------------------------------------

Thanks for the look Rushabh. In the cases we ran into, the corrupted image was 
loadable after bypassing some checks during NameNode startup. IAC there are 
couple of safeguards against losing the older image:
# The default value of {{dfs.namenode.num.checkpoints.retained}} is 2, so the 
older image is not lost.
# The purge step is skipped if a bad image was written.

bq. We can default to always exit and if someone is ok having their image 
corrupted then they can set it to not exit.
I am okay with changing the default behavior to just exit if corruption is 
detected, if the community is fine with it. I expect leaving the default 
behavior unchanged will be less controversial.

> NameNode should optionally exit if it detects FsImage corruption
> ----------------------------------------------------------------
>
>                 Key: HDFS-13314
>                 URL: https://issues.apache.org/jira/browse/HDFS-13314
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>            Priority: Major
>         Attachments: HDFS-13314.01.patch, HDFS-13314.02.patch
>
>
> The NameNode should optionally exit after writing an FsImage if it detects 
> the following kinds of corruptions:
> # INodeReference pointing to non-existent INode
> # Duplicate entries in snapshot deleted diff list.
> This behavior is controlled via an undocumented configuration setting, and 
> disabled by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to