[ 
https://issues.apache.org/jira/browse/HDFS-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405570#comment-16405570
 ] 

Erik Krogen edited comment on HDFS-13265 at 3/19/18 11:03 PM:
--------------------------------------------------------------

Hey [~chris.douglas], sorry for the slow response, I have been busy with other 
things the past few days and will continue to be for a bit longer, but do plan 
to pick this up and complete it. I think you are correct that we do not need 
HADOOP-15311 in branch-2 but need to reconfirm.

The patches as they are have changes that are meant for HDFS-13272, not this 
ticket. A lot of the savings come from that portion (reducing the DataNode HTTP 
handler threads), so I think it is not that useful to commit this ticket until 
we can get that in. Can you help with that?

Also, do you know why precommit has run for branch-2? Is this a test infra 
issue?


was (Author: xkrogen):
Hey [~chris.douglas], sorry for the slow response, I have been busy with other 
things the past few days and will continue to be, but do plan to pick this up 
and complete it. I think you are correct that we do not need HDFS-15311 in 
branch-2 but need to reconfirm.

The patches as they are have changes that are meant for HDFS-13272, not this 
ticket. A lot of the savings come from that portion (reducing the DataNode HTTP 
handler threads), so I think it is not that useful to commit this ticket until 
we can get that in. Can you help with that?

Also, do you know why precommit has run for branch-2? Is this a test infra 
issue?

> MiniDFSCluster should set reasonable defaults to reduce resource consumption
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-13265
>                 URL: https://issues.apache.org/jira/browse/HDFS-13265
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode, namenode, test
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Major
>         Attachments: HDFS-13265-branch-2.000.patch, 
> HDFS-13265-branch-2.000.patch, HDFS-13265.000.patch, 
> TestMiniDFSClusterThreads.java
>
>
> MiniDFSCluster takes its defaults from {{DFSConfigKeys}} defaults, but many 
> of these are not suitable for a unit test environment. For example, the 
> default handler thread count of 10 is definitely more than necessary for 
> (almost?) any unit test. We should set reasonable, lower defaults unless a 
> test specifically requires more.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to