[
https://issues.apache.org/jira/browse/HDFS-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405652#comment-16405652
]
Bharat Viswanadham commented on HDFS-13055:
-------------------------------------------
Hi [~ajayydv]
Thanks for the patch.
LGTM. with few minor comments and checkstyle issues need to be fixed.
1. In DatanodeUsageReport.java
{code:java}
/**
* An object representing a DataNodeUsageReport with no entries. Should
* be used instead of null or creating new objects when there are
* no statistics to report.
*/{code}
Not clear, what do you mean by no entries here?
2. And the method getDNUsageReport in DatanodeMetrics.java, will it be used in
further jira, to report status to NN?
3. And can we rename the writeBlockOp, readBlockOp to blocksWritten, blocksRead
in DataNodeUsageReportUtil.java
which will be clear to understand, as defined like in the DatanodeMetrics.java
4. And can we rename writeBlockPerSec, readBlockPerSec to blocksWrittenPerSec
and blocksReadPerSec.
> Aggregate usage statistics from datanodes
> -----------------------------------------
>
> Key: HDFS-13055
> URL: https://issues.apache.org/jira/browse/HDFS-13055
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDFS-13055.001.patch, HDFS-13055.002.patch,
> HDFS-13055.003.patch, HDFS-13055.004.patch, HDFS-13055.005.patch,
> HDFS-13055.006.patch, HDFS-13055.007.patch, HDFS-13055.008.patch,
> HDFS-13055.009.patch
>
>
> We collect variety of statistics in DataNodes and expose them via JMX.
> Aggregating some of the high level statistics which we are already collecting
> in {{DataNodeMetrics}} (like bytesRead,bytesWritten etc) over a configurable
> time window will create a central repository accessible via JMX and UI.
> Breaking this into 3 parts as suggested by [~arpitagarwal]
> # Generate usage report on DN. (will handle in this jira)
> # Pass usage report to NN periodically.
> # Process report on NN and expose stats via JMX.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
