[
https://issues.apache.org/jira/browse/HDFS-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405734#comment-16405734
]
Yiqun Lin commented on HDFS-13215:
----------------------------------
Thanks [~ywskycn] for the hard work! Just one comment for the patch
HDFS-13215_branch-2.9.002.patch
and HDFS-13215_branch-3.0.001.patch. In branch-2.9 and branch-3.0, we didn't
merge global quota implementation. So the following change for this two branch
should be removed:
*RBFConfigKeys.java*
{noformat}
+ // HDFS Router-based federation quota
+ public static final String DFS_ROUTER_QUOTA_ENABLE =
+ FEDERATION_ROUTER_PREFIX + "quota.enable";
+ public static final boolean DFS_ROUTER_QUOTA_ENABLED_DEFAULT = false;
+ public static final String DFS_ROUTER_QUOTA_CACHE_UPATE_INTERVAL =
+ FEDERATION_ROUTER_PREFIX + "quota-cache.update.interval";
+ public static final long DFS_ROUTER_QUOTA_CACHE_UPATE_INTERVAL_DEFAULT =
+ 60000;
{noformat}
*hdfs-rbf-default.xml*
{noformat}
+ <property>
+ <name>dfs.federation.router.quota.enable</name>
+ <value>false</value>
+ <description>
+ Set to true to enable quota system in Router.
+ </description>
+ </property>
+
+ <property>
+ <name>dfs.federation.router.quota-cache.update.interval</name>
+ <value>60s</value>
+ <description>
+ Interval time for updating quota usage cache in Router.
+ This property is used only if the value of
+ dfs.federation.router.quota.enable is true.
+ This setting supports multiple time unit suffixes as described
+ in dfs.heartbeat.interval. If no suffix is specified then milliseconds
+ is assumed.
+ </description>
+ </property>
{noformat}
Others looks good to me.
> RBF: Move Router to its own module
> ----------------------------------
>
> Key: HDFS-13215
> URL: https://issues.apache.org/jira/browse/HDFS-13215
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Wei Yan
> Priority: Major
> Attachments: HDFS-13215.000.patch, HDFS-13215.001.patch,
> HDFS-13215.002.patch, HDFS-13215.003.patch, HDFS-13215.004.patch,
> HDFS-13215.005.patch, HDFS-13215.006.patch, HDFS-13215.007.patch,
> HDFS-13215.008.patch, HDFS-13215.009.patch, HDFS-13215_branch-2.001.patch,
> HDFS-13215_branch-2.002.patch, HDFS-13215_branch-2.9.001.patch,
> HDFS-13215_branch-2.9.002.patch, HDFS-13215_branch-3.0.001.patch,
> HDFS-13215_branch-3.1.001.patch
>
>
> We are splitting the HDFS client code base and potentially Router-based
> Federation is also independent enough to be in its own package.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
