[
https://issues.apache.org/jira/browse/HDFS-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407224#comment-16407224
]
Hanisha Koneru edited comment on HDFS-13277 at 3/20/18 11:29 PM:
-----------------------------------------------------------------
Thanks for the patch [~bharatviswa].
LGTM overall (still have to review unit test). Just have a few very minor
comments:
# In {{ReplicaTrashInfo}}, it would be good to rename {{entries}} to
{{numBlocks}} as we are tracking the number of blocks in a subDir.
# Can you rename {{curDir}} to indicate that it is the current ReplicaTrash
subdir. Maybe {{curSubDir}} or {{curReplicaTrashSubDir?}}
was (Author: hanishakoneru):
Thanks for the patch [~bharatviswa].
LGTM overall (still have to review unit test). Just have a few very minor
comments:
# In {{ReplicaTrashInfo}}, it would be good to rename {{entries}} to
{{numBlocks}} as we are tracking the number of blocks in a subDir.
# Can you rename \{{curDir}} to indicate that it is the current ReplicaTrash
subdir. So that it is not confused with the current directory of the block
pool. Maybe {{curSubDir}} or {{curReplicaTrashSubDir?}}{{}}
> Improve move to account for usage (number of files) to limit trash dir size
> ---------------------------------------------------------------------------
>
> Key: HDFS-13277
> URL: https://issues.apache.org/jira/browse/HDFS-13277
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDFS-13277-HDFS-12996.00.patch,
> HDFS-13277-HDFS-12996.01.patch
>
>
> The trash subdirectory maximum entries. This puts an upper limit on the size
> of subdirectories in replica-trash. Set this default value to
> blockinvalidateLimit.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
