[ 
https://issues.apache.org/jira/browse/HDFS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055292#comment-13055292
 ] 

Aaron T. Myers commented on HDFS-1723:
--------------------------------------

Thanks for addressing my comments, Jim. I should have noticed this earlier, but 
I have one final comment and then I'll give it a +1 / commit it:

Earlier in the test we're explicitly setting the quota value to 1k, so we might 
as well explicitly test that the output is 1.0k, rather than have a regex which 
will match it. We wouldn't want this test to pass if it output, for example, 
"quota=9.5k"

> quota errors messages should use the same scale
> -----------------------------------------------
>
>                 Key: HDFS-1723
>                 URL: https://issues.apache.org/jira/browse/HDFS-1723
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: Allen Wittenauer
>            Assignee: Jim Plush
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.23.0
>
>         Attachments: HDFS-1723-take1.txt, HDFS-1723-take2.txt, 
> HDFS-1723-take3.txt
>
>
> A typical error message looks like this:
> org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: 
> org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: The DiskSpace quota 
> of /dir is exceeded: quota=3298534883328 diskspace consumed=5246.0g
> Since the two values are in difference scales and one is replicated vs. not 
> replicated (I think), this isn't very easy for the user to understand.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to