[
https://issues.apache.org/jira/browse/HDFS-12792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410066#comment-16410066
]
Ajay Kumar commented on HDFS-12792:
-----------------------------------
[~elgoiri], patch v11 looks good. Few comments:
# TestNamenodeHeartbeat seems specifically for router based federation,
keeping that in mind either we should rename it or split it into an abstract
class and its implementation for router based federation.
# RouterHDFSContract L72: An exception during laster stages of cluster
creation may result in some components being already started. In that case i
think its better to call \{{destroyCluster}} instead of setting it to null;
# MiniRouterDFSCluster#getRandomRouter: Shall we move Random instance to be a
static class variable?
# Rename FederationTestUtils#waitAnyNamenodeRegistered to
FederationTestUtils#waitNamenodeRegistered
+1 with these addressed
> RBF: Test Router-based federation using HDFSContract
> ----------------------------------------------------
>
> Key: HDFS-12792
> URL: https://issues.apache.org/jira/browse/HDFS-12792
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Labels: RBF
> Attachments: HDFS-12615.000.patch, HDFS-12792.001.patch,
> HDFS-12792.002.patch, HDFS-12792.003.patch, HDFS-12792.004.patch,
> HDFS-12792.005.patch, HDFS-12792.006.patch, HDFS-12792.007.patch,
> HDFS-12792.008.patch, HDFS-12792.009.patch, HDFS-12792.010.patch,
> HDFS-12792.011.patch, HDFS-12792.012.patch
>
>
> Router-based federation should support HDFSContract.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
