[ 
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412234#comment-16412234
 ] 

Gang Li commented on HDFS-13326:
--------------------------------

 

Hi, guys, currently the add and update functionalities are mixed in one 
function. To better separate them and make them complete and clear, I have the 
following thoughts about add, update and rm commands. So i am thinking add 
command can only add new source or new name service. If both the source and 
name service already exist, let it fail. Update command can only update 
existing source. If the source does not exist, let it fail. Rm command can 
remove a source or a name service. 

For example,

add m1 ns1, ns2 /a

if  m1 exists:

   ns1 or ns2 exists: fail

   else: add them 

else: add them

 

update m1 ns1 /a 

if m1 exists:

   if ns1 exists: update the dest or other options 

   else: use 'ns1 /a'  to overwrite m1's name services and destinations

else: fail

 

rm m1 ns2

if ns2 is provided, just remove ns2

if ns2 is not provided, remove m1

 

Please let me know how you think of them. Feel free to comment.  

> RBF: Improve the interfaces to modify and view mount tables
> -----------------------------------------------------------
>
>                 Key: HDFS-13326
>                 URL: https://issues.apache.org/jira/browse/HDFS-13326
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Wei Yan
>            Assignee: Gang Li
>            Priority: Minor
>
> 1. From DFSRouterAdmin cmd, currently the update logic is implemented inside 
> add operation, where it has some limitation (e.g. cannot update "readonly" or 
> removing a destination).  Given the RPC alreadys separate add and update 
> operations, it would be better to do the same in cmd level.
> 2. Currently in the MountTable tab, the "readonly" field always show empty, 
> no matter whether the mount entry is readonly or not. From the code 
> perspective, it tries to show:
> {code:java}
> <td class="dfshealth-node-icon dfshealth-mount-read-only-{readonly}"/>{code}
> The federationhealth.html will load hadoop.css, however the hadoop.css 
> doesn't have classes with a prefix "dfshealth-mount-read-only". This could be 
> fixed in HDFS-13204.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to