[
https://issues.apache.org/jira/browse/HDFS-13347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413602#comment-16413602
]
Yiqun Lin commented on HDFS-13347:
----------------------------------
I'm +1 for this idea. Some review comments for the patch:
* Define a static final variable for expire time {{10}}, instead of the dead
code.
* Why we change the parameter value of {{requireResponse}}, is that the
intended change?
* One typo: {{Gettings}} should be {{Getting}}.
* It would be better to add a test for verifying the cache behavior.
> RBF: Cache datanode reports
> ---------------------------
>
> Key: HDFS-13347
> URL: https://issues.apache.org/jira/browse/HDFS-13347
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Minor
> Attachments: HDFS-13347.000.patch
>
>
> Getting the datanode reports is an expensive operation and can be executed
> very frequently by the UI and watchdogs. We should cache this information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
