[
https://issues.apache.org/jira/browse/HDFS-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414562#comment-16414562
]
Chris Douglas commented on HDFS-8979:
-------------------------------------
bq. The patch did not break HDFS-13330, if you understand the problem of that
retry logic correctly
It did not break the retry loop, but the fix to the checkstyle warning missed
the actual problem. Checkstyle warnings aren't only cosmetic. Resolving
HDFS-8979 and HDFS-13330, we would remove the signal from checkstyle where we
had a real bug. Bulk fixes make it difficult for reviewers to find cases like
HDFS-13330 that deserve closer attention.
bq. Unless someone volunteers to review such huge patch again, I am inclined to
revert this patch from all branches.
We're more likely to introduce new bugs by reverting this. It's a large patch,
covering a large swath of the codebase, committed more than two years ago. Most
of the fixes are correct.
If we're going to take a lesson from this, then we should probably avoid
backporting bulk fixes from static analysis tools. While it can make subsequent
backports smoother by keeping the code similar, the analysis only applies to
the branch on which the tool is run e.g., if it can prove something dead in
trunk, that doesn't mean it's dead in the backported code.
> Clean up checkstyle warnings in hadoop-hdfs-client module
> ---------------------------------------------------------
>
> Key: HDFS-8979
> URL: https://issues.apache.org/jira/browse/HDFS-8979
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Priority: Major
> Fix For: 2.8.0, 3.0.0-alpha1
>
> Attachments: HDFS-8979.000.patch, HDFS-8979.001.patch,
> HDFS-8979.002.patch
>
>
> This jira tracks the effort of cleaning up checkstyle warnings in
> {{hadoop-hdfs-client}} module.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
