[
https://issues.apache.org/jira/browse/HDFS-13314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416260#comment-16416260
]
Arpit Agarwal edited comment on HDFS-13314 at 3/27/18 10:10 PM:
----------------------------------------------------------------
bq. if numErrors == 0 then namenode should not exit.
We test this code path since we have many unit tests that exercise
saveNamespace. e.g. multiple test cases in TestFSImage would fail if NN exits
when numErrors == 0.
bq. if numErrors > 0 then namenode should exit.
No easy way to do so without refactoring existing classes or inserting some
test hooks. I don't think it is worth the effort. Do you feel it is a blocker
to committing this validation?
was (Author: arpitagarwal):
bq. if numErrors == 0 then namenode should not exit.
We test this code path since we have many unit tests that exercise
saveNamespace. e.g. multiple test cases in TestFSImage would fail if NN exits
when numErrors == 0.
bq. if numErrors > 0 then namenode should exit.
No easy way to do so without refactoring or inserting test hooks. I don't think
it is worth the effort. Do you feel it is a blocker to committing this
validation?
> NameNode should optionally exit if it detects FsImage corruption
> ----------------------------------------------------------------
>
> Key: HDFS-13314
> URL: https://issues.apache.org/jira/browse/HDFS-13314
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Priority: Major
> Attachments: HDFS-13314.01.patch, HDFS-13314.02.patch,
> HDFS-13314.03.patch, HDFS-13314.04.patch, HDFS-13314.05.patch
>
>
> The NameNode should optionally exit after writing an FsImage if it detects
> the following kinds of corruptions:
> # INodeReference pointing to non-existent INode
> # Duplicate entries in snapshot deleted diff list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
