[
https://issues.apache.org/jira/browse/HDFS-13347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416751#comment-16416751
]
Virajith Jalaparti commented on HDFS-13347:
-------------------------------------------
[~elgoiri], a couple of comments:
1) Mark the added {{getNamenodeMetrics()}} as {{@VisibleForTesting}}? Also,
these do not need to be public.
2) It would be good to add more documentation for the new {{requireResponse}}
parameter, something along the lines that if this is set to false, any failure
to get the reports will go unnoticed.
> RBF: Cache datanode reports
> ---------------------------
>
> Key: HDFS-13347
> URL: https://issues.apache.org/jira/browse/HDFS-13347
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.0.0
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Minor
> Fix For: 3.0.2, 3.2.0, 3.1.1
>
> Attachments: HDFS-13347.000.patch, HDFS-13347.001.patch,
> HDFS-13347.002.patch, HDFS-13347.003.patch, HDFS-13347.004.patch,
> HDFS-13347.005.patch, HDFS-13347.006.patch
>
>
> Getting the datanode reports is an expensive operation and can be executed
> very frequently by the UI and watchdogs. We should cache this information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
