[
https://issues.apache.org/jira/browse/HDFS-13328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422102#comment-16422102
]
Rakesh R edited comment on HDFS-13328 at 4/2/18 10:29 AM:
----------------------------------------------------------
Thanks [~surendrasingh] for the patch. Apart from the below minor comments, I'm
+1 for the patch.
# Please make the class private.
{code:java}
private class ReencryptionPendingInodeIdCollector{code}
# Please make it final
{code:java}
private final ReencryptionHandler reencryptionHandler;
private final ReencryptionPendingInodeIdCollector traverser;
private final FSDirectory dir;
{code}
was (Author: rakeshr):
Thanks [~surendrasingh] for the patch. Apart from the below minor comments, I'm
+1 for the patch.
# Please make the class private.
{code:java}
private class ReencryptionPendingInodeIdCollector{code}
# Please make it final
{code:java}
private final ReencryptionHandler reencryptionHandler;
private final ReencryptionPendingInodeIdCollector traverser;
private final FSDirectory dir;
{code}
> Abstract ReencryptionHandler recursive logic in separate class.
> ---------------------------------------------------------------
>
> Key: HDFS-13328
> URL: https://issues.apache.org/jira/browse/HDFS-13328
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Priority: Major
> Attachments: HDFS-13328-01.patch
>
>
> HDFS-10899 added DFS logic to scan a directory. It is good to abstract this
> logic in separate class, so it can be used in some other feature like
> SPS(HDFS-10285). I already tried abstracting DFS logic in HDFS-12291 and same
> can be pushed in trunk.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
