[ https://issues.apache.org/jira/browse/HDFS-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422883#comment-16422883 ]
Plamen Jeliazkov edited comment on HDFS-13331 at 4/2/18 6:00 PM: ----------------------------------------------------------------- Thanks [~xkrogen] -- I debated whether to do the static field work now or in follow-up for a while and I think in follow-up will help make my patch more focused. I think I am able to do it by passing it through {{Call}} object though. As for your points, I agree with them except that for (1) I do not intend the log statement to last long and therefore would opt not to rely on a log capture. Log capture tests are a little hacky as well. If you would really like me to remove the {{@Ignored}} however I can just remove it for now and update the test later. I should have a patch by EOD today. was (Author: zero45): Thanks [~xkrogen] -- I debated whether to do the static field work now or in follow-up for a while and I think in follow-up will help make my patch more focused. I think I am able to do it by passing it through {{Call}} object though. As for your points, I agree with them except that for (1) I do not intend the log statement to last long and therefore would opt not to rely on a log capture. Log capture tests are a little hacky as well. If you would really like me to remove the {{@Ignored}} however I can just remove it for now and update the test later. > Add lastSeenStateId to RpcRequestHeader. > ---------------------------------------- > > Key: HDFS-13331 > URL: https://issues.apache.org/jira/browse/HDFS-13331 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: HDFS-12943 > Reporter: Plamen Jeliazkov > Assignee: Plamen Jeliazkov > Priority: Major > Attachments: HDFS-13331-HDFS-12943.002.patch, > HDFS-13331-HDFS-12943.003..patch, HDFS-13331.trunk.001.patch, > HDFS_13331.trunk.000.patch > > > HDFS-12977 added a stateId into the RpcResponseHeader which is returned by > NameNode and stored by DFSClient. > This JIRA is to followup on that work and have the DFSClient send their > stored "lastSeenStateId" in the RpcRequestHeader so that ObserverNodes can > then compare with their own and act accordingly. > This JIRA work focuses on just the part of making DFSClient send their state > through RpcRequestHeader. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org