[ https://issues.apache.org/jira/browse/HDFS-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424408#comment-16424408 ]
genericqa commented on HDFS-13391: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 9m 6s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} HDFS-7240 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 34s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m 58s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 29m 45s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 19m 29s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 33s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 21s{color} | {color:green} HDFS-7240 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 23s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 36s{color} | {color:red} hadoop-cblock in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 29m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 29m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 20m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 2s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 12s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 20s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 42s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 51s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 8s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 46s{color} | {color:red} The patch generated 70 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}222m 35s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.conf.TestCommonConfigurationFields | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:b78c94f | | JIRA Issue | HDFS-13391 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12917375/HDFS-13391-HDFS-7240.000.patch | | Optional Tests | asflicense shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xml | | uname | Linux 7ff9a645e3f4 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HDFS-7240 / ac77b18 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_162 | | shellcheck | v0.4.6 | | mvninstall | https://builds.apache.org/job/PreCommit-HDFS-Build/23762/artifact/out/patch-mvninstall-hadoop-cblock.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23762/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/23762/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HDFS-Build/23762/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 1347 (vs. ulimit of 10000) | | modules | C: . hadoop-cblock hadoop-hdsl hadoop-hdsl/client hadoop-hdsl/common hadoop-hdsl/container-service hadoop-hdsl/framework hadoop-hdsl/server-scm hadoop-hdsl/tools hadoop-ozone hadoop-ozone/client hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/objectstore-service hadoop-ozone/ozone-manager hadoop-ozone/tools hadoop-tools/hadoop-ozone U: . | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/23762/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Ozone: Make dependency of internal sub-module scope as provided in maven. > ------------------------------------------------------------------------- > > Key: HDFS-13391 > URL: https://issues.apache.org/jira/browse/HDFS-13391 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Reporter: Nanda kumar > Assignee: Nanda kumar > Priority: Major > Attachments: HDFS-13391-HDFS-7240.000.patch > > > Whenever an internal sub-module is added as a dependency the scope has to be > set to {{provided}}. > If the scope is not mentioned it falls back to default scope which is > {{compile}}, this makes the dependency jar (sub-module jar) to be copied to > {{share/..../lib}} directory while packaging. Since we use > {{copyifnotexists}} logic, the binary jar of the actual sub-module will not > be copied. This will result in the jar being placed in the wrong location > inside the distribution. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org