[ 
https://issues.apache.org/jira/browse/HDFS-13045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426242#comment-16426242
 ] 

Íñigo Goiri commented on HDFS-13045:
------------------------------------

Attached  [^HDFS-13045.003.patch] which actually works.
Thanks [~ywskycn] for the comments, the idea of that code is to track 
subfolders, for example for this case:
{code}
    try {
      FsPermission permission = new FsPermission("777");
      routerProtocol.mkdirs("/mnt/folder0/folder1", permission, false);
      fail("mkdirs for non-existing parent folder should have failed");
    } catch (IOException ioe) {
      assertExceptionContains("/mnt/folder0", ioe,
          "Wrong exception for mkdirs");
    }
{code}

However, the original version had an infinite loop there; tweaked it a little.
Regarding the double replacement, yes we should cover that; we may already 
cover it as we try to replace the largest right now.
Can you come up with a unit test for that?

> RBF: Improve error message returned from subcluster
> ---------------------------------------------------
>
>                 Key: HDFS-13045
>                 URL: https://issues.apache.org/jira/browse/HDFS-13045
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>            Priority: Minor
>         Attachments: HDFS-13045.000.patch, HDFS-13045.001.patch, 
> HDFS-13045.002.patch
>
>
> Currently, Router directly returns exception response from subcluster to 
> client, which may not have the correct error message, especially when the 
> error message containing a path.
> One example, we have a mount path "/a/b" mapped to subclusterA's "/c/d". If 
> user1 does a chown operation on "/a/b", and he doesn't have corresponding 
> privilege, currently the error msg looks like "Permission denied. user=user1 
> is not the owner of inode=/c/d", which may confuse user. Would be better to 
> reverse the path back to original mount path.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to